Skip to content

Fix NullPointerException on samplers#11230

Open
jpbempel wants to merge 2 commits intomasterfrom
jpbempel/fix-npe-proberatelimiter
Open

Fix NullPointerException on samplers#11230
jpbempel wants to merge 2 commits intomasterfrom
jpbempel/fix-npe-proberatelimiter

Conversation

@jpbempel
Copy link
Copy Markdown
Member

@jpbempel jpbempel commented Apr 29, 2026

What Does This Do

In some rare cases samplers are null for LogProbe because they are initialize separately in applyRateLimiter for new definitions. To fix this we refactor the way probe are deserialized when received from RC in a dedicated class where samplers are also initialized earlier and not based on new definitions compared to existing Configuration.
SpanDecorationProbe created by builders are initialized in dedicated constructor.
Introduce builder to TriggerProbe with same mechanism than other probes to harmonize.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [DEBUG-5506]

Note: Once your PR is ready to merge, add it to the merge queue by commenting /merge. /merge -c cancels the queue request. /merge -f --reason "reason" skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.

@jpbempel jpbempel requested a review from a team as a code owner April 29, 2026 12:06
@jpbempel jpbempel requested review from tylfin and removed request for a team April 29, 2026 12:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 29, 2026 •
edited
Loading

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 29, 2026 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1777573890 1777574236
end_time 2026-04-30T18:32:54 2026-04-30T18:38:40
git_branch master jpbempel/fix-npe-proberatelimiter
git_commit_sha abe7711 8c987f9
start_time 2026-04-30T18:31:31 2026-04-30T18:37:17
See matching parameters
Baseline Candidate
ci_job_id 1647513896 1647513896
ci_pipeline_id 110777267 110777267
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1777573434 1777573434

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-16.327µs; +22.063µs] or [-5.708%; +7.714%]		 unstable
[-25.096µs; +34.926µs] or [-7.680%; +10.688%]		 unstable
[-34.342µs; +47.355µs] or [-10.053%; +13.863%]		 unstable
[-191.053µs; +21.417µs] or [-15.544%; +1.742%]		 same
scenario:basic same same same unstable
[-565.202µs; -245.036µs] or [-40.316%; -17.478%]		 unstable
[-170.179op/s; +170.179op/s] or [-6.807%; +6.807%]
scenario:loop same same same same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (326.766 µs) : 303, 351
.   : milestone, 327,
basic (291.947 µs) : 285, 299
.   : milestone, 292,
loop (8.968 ms) : 8963, 8974
.   : milestone, 8968,
section candidate
noprobe (331.681 µs) : 299, 364
.   : milestone, 332,
basic (292.666 µs) : 286, 300
.   : milestone, 293,
loop (8.967 ms) : 8961, 8972
.   : milestone, 8967,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 326.766 µs [302.736 µs, 350.797 µs]
basic 291.947 µs [285.112 µs, 298.782 µs]
loop 8.968 ms [8.963 ms, 8.974 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 331.681 µs [299.245 µs, 364.117 µs]
basic 292.666 µs [285.752 µs, 299.579 µs]
loop 8.967 ms [8.961 ms, 8.972 ms]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 29, 2026

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-npe-proberatelimiter
git_commit_date 1777321489 1777464318
git_commit_sha 75fe2b3 9bab6d1
release_version 1.62.0-SNAPSHOT~75fe2b3c55 1.62.0-SNAPSHOT~9bab6d143c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1777466091 1777466091
ci_job_id 1641830868 1641830868
ci_pipeline_id 110406535 110406535
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-1fp72lkj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-1fp72lkj 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.062 s) : 0, 1061930
Total [baseline] (8.842 s) : 0, 8842323
Agent [candidate] (1.063 s) : 0, 1063261
Total [candidate] (8.837 s) : 0, 8836726
section iast
Agent [baseline] (1.244 s) : 0, 1243844
Total [baseline] (9.522 s) : 0, 9521713
Agent [candidate] (1.242 s) : 0, 1242108
Total [candidate] (9.519 s) : 0, 9519451
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.062 s -
Agent iast 1.244 s 181.913 ms (17.1%)
Total tracing 8.842 s -
Total iast 9.522 s 679.389 ms (7.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.242 s 178.847 ms (16.8%)
Total tracing 8.837 s -
Total iast 9.519 s 682.725 ms (7.7%) 
gantt
    title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.23 ms) : 0, 1230
crashtracking [candidate] (1.229 ms) : 0, 1229
BytebuddyAgent [baseline] (635.922 ms) : 0, 635922
BytebuddyAgent [candidate] (635.157 ms) : 0, 635157
AgentMeter [baseline] (29.523 ms) : 0, 29523
AgentMeter [candidate] (29.475 ms) : 0, 29475
GlobalTracer [baseline] (248.724 ms) : 0, 248724
GlobalTracer [candidate] (249.286 ms) : 0, 249286
AppSec [baseline] (32.681 ms) : 0, 32681
AppSec [candidate] (32.8 ms) : 0, 32800
Debugger [baseline] (59.741 ms) : 0, 59741
Debugger [candidate] (59.953 ms) : 0, 59953
Remote Config [baseline] (601.174 µs) : 0, 601
Remote Config [candidate] (599.249 µs) : 0, 599
Telemetry [baseline] (9.151 ms) : 0, 9151
Telemetry [candidate] (10.623 ms) : 0, 10623
Flare Poller [baseline] (8.291 ms) : 0, 8291
Flare Poller [candidate] (8.196 ms) : 0, 8196
section iast
crashtracking [baseline] (1.231 ms) : 0, 1231
crashtracking [candidate] (1.223 ms) : 0, 1223
BytebuddyAgent [baseline] (823.34 ms) : 0, 823340
BytebuddyAgent [candidate] (822.532 ms) : 0, 822532
AgentMeter [baseline] (11.292 ms) : 0, 11292
AgentMeter [candidate] (11.269 ms) : 0, 11269
GlobalTracer [baseline] (237.489 ms) : 0, 237489
GlobalTracer [candidate] (237.463 ms) : 0, 237463
IAST [baseline] (27.335 ms) : 0, 27335
IAST [candidate] (28.072 ms) : 0, 28072
AppSec [baseline] (32.353 ms) : 0, 32353
AppSec [candidate] (31.583 ms) : 0, 31583
Debugger [baseline] (62.884 ms) : 0, 62884
Debugger [candidate] (62.215 ms) : 0, 62215
Remote Config [baseline] (530.374 µs) : 0, 530
Remote Config [candidate] (516.454 µs) : 0, 516
Telemetry [baseline] (7.915 ms) : 0, 7915
Telemetry [candidate] (7.896 ms) : 0, 7896
Flare Poller [baseline] (3.393 ms) : 0, 3393
Flare Poller [candidate] (3.352 ms) : 0, 3352
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.075 s) : 0, 1074821
Total [baseline] (11.072 s) : 0, 11071882
Agent [candidate] (1.066 s) : 0, 1066192
Total [candidate] (11.058 s) : 0, 11057691
section appsec
Agent [baseline] (1.265 s) : 0, 1265419
Total [baseline] (11.052 s) : 0, 11051717
Agent [candidate] (1.275 s) : 0, 1274797
Total [candidate] (11.126 s) : 0, 11126050
section iast
Agent [baseline] (1.242 s) : 0, 1241959
Total [baseline] (11.177 s) : 0, 11176563
Agent [candidate] (1.241 s) : 0, 1241142
Total [candidate] (11.319 s) : 0, 11318577
section profiling
Agent [baseline] (1.192 s) : 0, 1192361
Total [baseline] (11.009 s) : 0, 11008629
Agent [candidate] (1.183 s) : 0, 1182915
Total [candidate] (10.983 s) : 0, 10982781
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.075 s -
Agent appsec 1.265 s 190.598 ms (17.7%)
Agent iast 1.242 s 167.138 ms (15.6%)
Agent profiling 1.192 s 117.541 ms (10.9%)
Total tracing 11.072 s -
Total appsec 11.052 s -20.165 ms (-0.2%)
Total iast 11.177 s 104.68 ms (0.9%)
Total profiling 11.009 s -63.254 ms (-0.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.066 s -
Agent appsec 1.275 s 208.606 ms (19.6%)
Agent iast 1.241 s 174.95 ms (16.4%)
Agent profiling 1.183 s 116.723 ms (10.9%)
Total tracing 11.058 s -
Total appsec 11.126 s 68.359 ms (0.6%)
Total iast 11.319 s 260.887 ms (2.4%)
Total profiling 10.983 s -74.91 ms (-0.7%) 
gantt
    title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.234 ms) : 0, 1234
crashtracking [candidate] (1.224 ms) : 0, 1224
BytebuddyAgent [baseline] (641.393 ms) : 0, 641393
BytebuddyAgent [candidate] (637.301 ms) : 0, 637301
AgentMeter [baseline] (30.023 ms) : 0, 30023
AgentMeter [candidate] (29.654 ms) : 0, 29654
GlobalTracer [baseline] (251.748 ms) : 0, 251748
GlobalTracer [candidate] (249.397 ms) : 0, 249397
AppSec [baseline] (33.214 ms) : 0, 33214
AppSec [candidate] (32.869 ms) : 0, 32869
Debugger [baseline] (61.398 ms) : 0, 61398
Debugger [candidate] (60.87 ms) : 0, 60870
Remote Config [baseline] (608.863 µs) : 0, 609
Remote Config [candidate] (598.942 µs) : 0, 599
Telemetry [baseline] (9.24 ms) : 0, 9240
Telemetry [candidate] (8.431 ms) : 0, 8431
Flare Poller [baseline] (9.75 ms) : 0, 9750
Flare Poller [candidate] (9.764 ms) : 0, 9764
section appsec
crashtracking [baseline] (1.227 ms) : 0, 1227
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (675.247 ms) : 0, 675247
BytebuddyAgent [candidate] (678.101 ms) : 0, 678101
AgentMeter [baseline] (12.251 ms) : 0, 12251
AgentMeter [candidate] (12.232 ms) : 0, 12232
GlobalTracer [baseline] (249.404 ms) : 0, 249404
GlobalTracer [candidate] (251.995 ms) : 0, 251995
IAST [baseline] (24.689 ms) : 0, 24689
IAST [candidate] (25.154 ms) : 0, 25154
AppSec [baseline] (185.847 ms) : 0, 185847
AppSec [candidate] (186.842 ms) : 0, 186842
Debugger [baseline] (64.455 ms) : 0, 64455
Debugger [candidate] (65.815 ms) : 0, 65815
Remote Config [baseline] (566.668 µs) : 0, 567
Remote Config [candidate] (573.994 µs) : 0, 574
Telemetry [baseline] (7.841 ms) : 0, 7841
Telemetry [candidate] (8.093 ms) : 0, 8093
Flare Poller [baseline] (7.292 ms) : 0, 7292
Flare Poller [candidate] (8.087 ms) : 0, 8087
section iast
crashtracking [baseline] (1.235 ms) : 0, 1235
crashtracking [candidate] (1.226 ms) : 0, 1226
BytebuddyAgent [baseline] (821.407 ms) : 0, 821407
BytebuddyAgent [candidate] (820.977 ms) : 0, 820977
AgentMeter [baseline] (11.277 ms) : 0, 11277
AgentMeter [candidate] (11.255 ms) : 0, 11255
GlobalTracer [baseline] (237.635 ms) : 0, 237635
GlobalTracer [candidate] (238.922 ms) : 0, 238922
IAST [baseline] (28.863 ms) : 0, 28863
IAST [candidate] (28.032 ms) : 0, 28032
AppSec [baseline] (29.064 ms) : 0, 29064
AppSec [candidate] (29.803 ms) : 0, 29803
Debugger [baseline] (63.774 ms) : 0, 63774
Debugger [candidate] (63.031 ms) : 0, 63031
Remote Config [baseline] (519.411 µs) : 0, 519
Remote Config [candidate] (523.236 µs) : 0, 523
Telemetry [baseline] (7.943 ms) : 0, 7943
Telemetry [candidate] (7.984 ms) : 0, 7984
Flare Poller [baseline] (3.397 ms) : 0, 3397
Flare Poller [candidate] (3.356 ms) : 0, 3356
section profiling
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (696.126 ms) : 0, 696126
BytebuddyAgent [candidate] (689.359 ms) : 0, 689359
AgentMeter [baseline] (8.926 ms) : 0, 8926
AgentMeter [candidate] (8.889 ms) : 0, 8889
GlobalTracer [baseline] (208.932 ms) : 0, 208932
GlobalTracer [candidate] (207.749 ms) : 0, 207749
AppSec [baseline] (32.702 ms) : 0, 32702
AppSec [candidate] (32.716 ms) : 0, 32716
Debugger [baseline] (66.059 ms) : 0, 66059
Debugger [candidate] (65.67 ms) : 0, 65670
Remote Config [baseline] (581.843 µs) : 0, 582
Remote Config [candidate] (571.385 µs) : 0, 571
Telemetry [baseline] (8.119 ms) : 0, 8119
Telemetry [candidate] (8.081 ms) : 0, 8081
Flare Poller [baseline] (3.599 ms) : 0, 3599
Flare Poller [candidate] (3.54 ms) : 0, 3540
ProfilingAgent [baseline] (94.177 ms) : 0, 94177
ProfilingAgent [candidate] (93.776 ms) : 0, 93776
Profiling [baseline] (94.731 ms) : 0, 94731
Profiling [candidate] (94.353 ms) : 0, 94353
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-npe-proberatelimiter
git_commit_date 1777321489 1777464318
git_commit_sha 75fe2b3 9bab6d1
release_version 1.62.0-SNAPSHOT~75fe2b3c55 1.62.0-SNAPSHOT~9bab6d143c
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1777466574 1777466574
ci_job_id 1641830870 1641830870
ci_pipeline_id 110406535 110406535
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-lx4u28tq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-lx4u28tq 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 2 performance regressions! Performance is the same for 19 metrics, 15 unstable metrics.

scenario Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p95 Δ mean throughput candidate mean agg_http_req_duration_p50 candidate mean agg_http_req_duration_p95 candidate mean throughput baseline mean agg_http_req_duration_p50 baseline mean agg_http_req_duration_p95 baseline mean throughput
scenario:load:insecure-bank:iast_FULL:high_load worse
[+171.296µs; +484.925µs] or [+3.238%; +9.166%]		 unsure
[+90.254µs; +649.651µs] or [+0.711%; +5.116%]		 unstable
[-110.162op/s; +54.474op/s] or [-14.346%; +7.094%]		 5.618ms 13.067ms 740.062op/s 5.290ms 12.697ms 767.906op/s
scenario:load:petclinic:code_origins:high_load worse
[+608.622µs; +1020.927µs] or [+3.539%; +5.936%]		 unsure
[+0.534ms; +1.547ms] or [+1.907%; +5.522%]		 unstable
[-36.313op/s; +14.938op/s] or [-13.684%; +5.629%]		 18.014ms 29.061ms 254.688op/s 17.199ms 28.020ms 265.375op/s
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.269 ms) : 1256, 1282
.   : milestone, 1269,
iast (3.368 ms) : 3317, 3419
.   : milestone, 3368,
iast_FULL (6.023 ms) : 5961, 6084
.   : milestone, 6023,
iast_GLOBAL (3.748 ms) : 3686, 3810
.   : milestone, 3748,
profiling (2.233 ms) : 2212, 2253
.   : milestone, 2233,
tracing (1.872 ms) : 1855, 1889
.   : milestone, 1872,
section candidate
no_agent (1.24 ms) : 1228, 1252
.   : milestone, 1240,
iast (3.367 ms) : 3319, 3414
.   : milestone, 3367,
iast_FULL (6.253 ms) : 6188, 6317
.   : milestone, 6253,
iast_GLOBAL (3.752 ms) : 3681, 3824
.   : milestone, 3752,
profiling (2.414 ms) : 2390, 2438
.   : milestone, 2414,
tracing (1.91 ms) : 1894, 1927
.   : milestone, 1910,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.269 ms [1.256 ms, 1.282 ms] -
iast 3.368 ms [3.317 ms, 3.419 ms] 2.099 ms (165.4%)
iast_FULL 6.023 ms [5.961 ms, 6.084 ms] 4.754 ms (374.7%)
iast_GLOBAL 3.748 ms [3.686 ms, 3.81 ms] 2.479 ms (195.4%)
profiling 2.233 ms [2.212 ms, 2.253 ms] 964.108 µs (76.0%)
tracing 1.872 ms [1.855 ms, 1.889 ms] 603.324 µs (47.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.24 ms [1.228 ms, 1.252 ms] -
iast 3.367 ms [3.319 ms, 3.414 ms] 2.127 ms (171.6%)
iast_FULL 6.253 ms [6.188 ms, 6.317 ms] 5.013 ms (404.4%)
iast_GLOBAL 3.752 ms [3.681 ms, 3.824 ms] 2.513 ms (202.7%)
profiling 2.414 ms [2.39 ms, 2.438 ms] 1.174 ms (94.7%)
tracing 1.91 ms [1.894 ms, 1.927 ms] 670.599 µs (54.1%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55
    dateFormat X
    axisFormat %s
section baseline
no_agent (19.141 ms) : 18946, 19336
.   : milestone, 19141,
appsec (18.667 ms) : 18481, 18854
.   : milestone, 18667,
code_origins (17.582 ms) : 17410, 17753
.   : milestone, 17582,
iast (17.983 ms) : 17807, 18160
.   : milestone, 17983,
profiling (18.446 ms) : 18262, 18630
.   : milestone, 18446,
tracing (17.879 ms) : 17701, 18056
.   : milestone, 17879,
section candidate
no_agent (18.256 ms) : 18073, 18440
.   : milestone, 18256,
appsec (18.845 ms) : 18659, 19031
.   : milestone, 18845,
code_origins (18.321 ms) : 18141, 18502
.   : milestone, 18321,
iast (17.873 ms) : 17693, 18052
.   : milestone, 17873,
profiling (18.223 ms) : 18043, 18403
.   : milestone, 18223,
tracing (17.974 ms) : 17795, 18152
.   : milestone, 17974,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 19.141 ms [18.946 ms, 19.336 ms] -
appsec 18.667 ms [18.481 ms, 18.854 ms] -473.758 µs (-2.5%)
code_origins 17.582 ms [17.41 ms, 17.753 ms] -1.559 ms (-8.1%)
iast 17.983 ms [17.807 ms, 18.16 ms] -1.158 ms (-6.0%)
profiling 18.446 ms [18.262 ms, 18.63 ms] -695.412 µs (-3.6%)
tracing 17.879 ms [17.701 ms, 18.056 ms] -1.262 ms (-6.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 18.256 ms [18.073 ms, 18.44 ms] -
appsec 18.845 ms [18.659 ms, 19.031 ms] 588.509 µs (3.2%)
code_origins 18.321 ms [18.141 ms, 18.502 ms] 65.044 µs (0.4%)
iast 17.873 ms [17.693 ms, 18.052 ms] -383.783 µs (-2.1%)
profiling 18.223 ms [18.043 ms, 18.403 ms] -33.533 µs (-0.2%)
tracing 17.974 ms [17.795 ms, 18.152 ms] -282.786 µs (-1.5%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jpbempel/fix-npe-proberatelimiter
git_commit_date 1777321489 1777464318
git_commit_sha 75fe2b3 9bab6d1
release_version 1.62.0-SNAPSHOT~75fe2b3c55 1.62.0-SNAPSHOT~9bab6d143c
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1777466323 1777466323
ci_job_id 1641830873 1641830873
ci_pipeline_id 110406535 110406535
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-wyzp1t2j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-wyzp1t2j 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.497 ms) : 1486, 1509
.   : milestone, 1497,
appsec (3.818 ms) : 3597, 4039
.   : milestone, 3818,
iast (2.292 ms) : 2222, 2361
.   : milestone, 2292,
iast_GLOBAL (2.337 ms) : 2266, 2407
.   : milestone, 2337,
profiling (2.125 ms) : 2070, 2180
.   : milestone, 2125,
tracing (2.094 ms) : 2040, 2148
.   : milestone, 2094,
section candidate
no_agent (1.494 ms) : 1483, 1506
.   : milestone, 1494,
appsec (3.846 ms) : 3622, 4071
.   : milestone, 3846,
iast (2.297 ms) : 2227, 2367
.   : milestone, 2297,
iast_GLOBAL (2.333 ms) : 2263, 2403
.   : milestone, 2333,
profiling (2.111 ms) : 2056, 2165
.   : milestone, 2111,
tracing (2.103 ms) : 2049, 2157
.   : milestone, 2103,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.497 ms [1.486 ms, 1.509 ms] -
appsec 3.818 ms [3.597 ms, 4.039 ms] 2.32 ms (155.0%)
iast 2.292 ms [2.222 ms, 2.361 ms] 794.248 µs (53.0%)
iast_GLOBAL 2.337 ms [2.266 ms, 2.407 ms] 839.385 µs (56.1%)
profiling 2.125 ms [2.07 ms, 2.18 ms] 627.335 µs (41.9%)
tracing 2.094 ms [2.04 ms, 2.148 ms] 596.568 µs (39.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.494 ms [1.483 ms, 1.506 ms] -
appsec 3.846 ms [3.622 ms, 4.071 ms] 2.352 ms (157.4%)
iast 2.297 ms [2.227 ms, 2.367 ms] 802.71 µs (53.7%)
iast_GLOBAL 2.333 ms [2.263 ms, 2.403 ms] 838.974 µs (56.1%)
profiling 2.111 ms [2.056 ms, 2.165 ms] 616.25 µs (41.2%)
tracing 2.103 ms [2.049 ms, 2.157 ms] 608.748 µs (40.7%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~9bab6d143c, baseline=1.62.0-SNAPSHOT~75fe2b3c55
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.727 s) : 15727000, 15727000
.   : milestone, 15727000,
appsec (14.474 s) : 14474000, 14474000
.   : milestone, 14474000,
iast (18.251 s) : 18251000, 18251000
.   : milestone, 18251000,
iast_GLOBAL (17.943 s) : 17943000, 17943000
.   : milestone, 17943000,
profiling (15.544 s) : 15544000, 15544000
.   : milestone, 15544000,
tracing (14.809 s) : 14809000, 14809000
.   : milestone, 14809000,
section candidate
no_agent (15.522 s) : 15522000, 15522000
.   : milestone, 15522000,
appsec (14.755 s) : 14755000, 14755000
.   : milestone, 14755000,
iast (18.587 s) : 18587000, 18587000
.   : milestone, 18587000,
iast_GLOBAL (17.763 s) : 17763000, 17763000
.   : milestone, 17763000,
profiling (15.083 s) : 15083000, 15083000
.   : milestone, 15083000,
tracing (14.731 s) : 14731000, 14731000
.   : milestone, 14731000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.727 s [15.727 s, 15.727 s] -
appsec 14.474 s [14.474 s, 14.474 s] -1.253 s (-8.0%)
iast 18.251 s [18.251 s, 18.251 s] 2.524 s (16.0%)
iast_GLOBAL 17.943 s [17.943 s, 17.943 s] 2.216 s (14.1%)
profiling 15.544 s [15.544 s, 15.544 s] -183.0 ms (-1.2%)
tracing 14.809 s [14.809 s, 14.809 s] -918.0 ms (-5.8%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.522 s [15.522 s, 15.522 s] -
appsec 14.755 s [14.755 s, 14.755 s] -767.0 ms (-4.9%)
iast 18.587 s [18.587 s, 18.587 s] 3.065 s (19.7%)
iast_GLOBAL 17.763 s [17.763 s, 17.763 s] 2.241 s (14.4%)
profiling 15.083 s [15.083 s, 15.083 s] -439.0 ms (-2.8%)
tracing 14.731 s [14.731 s, 14.731 s] -791.0 ms (-5.1%)

@jpbempel jpbempel added comp: debugger Dynamic Instrumentation type: bug Bug report and fix labels Apr 29, 2026
jpbempel added 2 commits April 30, 2026 20:23
@jpbempel
Fix NullPointerException on samplers
eef4d07 
In some rare cases samplers are null for LogProbe because they are
initialize separately in applyRateLimiter for new definitions.
To fix this we refactor the way probe are deserialized when received
from RC in a dedicated class where samplers are also initialized
earlier and not based on new definitions compared to existing
Configuration.
SpanDecorationProbe created by builders are initialized in dedicated
constructor.
Introduce builder to TriggerProbe with same mechanism than other
probes to harmonize.
@jpbempel
fix smoke test
8c987f9
@jpbempel jpbempel force-pushed the jpbempel/fix-npe-proberatelimiter branch from 688ffd6 to 8c987f9 Compare April 30, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tylfin tylfin tylfin approved these changes

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation type: bug Bug report and fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpbempel @tylfin